fix: revert base entity teleport changes, add warning to player controller (#688)

Co-authored-by: Michael Wilson <roflmuffin@users.noreply.github.com>

.github/workflows/publish-docs.yml

@@ -2,6 +2,7 @@ on:
   push:
     branches:
       - main
+  workflow_dispatch:  
 
 permissions:
   contents: read

docfx/docs/features/game-events.md

@@ -54,6 +54,9 @@ The specific subclass of `GameEvent` will provide strongly typed parameters from
 
 These event properties are mutable so you can update them as normal and they will update in the event instance.
 
+> [!CAUTION]
+> `GameEvent` instances and their properties will cease to exist after the event listener function is called, which means that you will encounter errors when accessing properties in timers and functions like `Server.NextFrame()`. You should store the value of properties in variables before calling functions like `Server.NextFrame()` so you can read the data safely.
+
 ## Preventing Broadcast
 
 You can modify a game event so that it does not get broadcast to clients by modifying the `bool info.DontBroadcast` property. e.g.

docfx/docs/guides/toc.yml

@@ -6,3 +6,6 @@
 
 - name: Dependency Injection
   href: dependency-injection.md
+
+- name: Referencing Players
+  href: referencing-players.md

docfx/docs/reference/toc.yml

@@ -1,5 +1,2 @@
 - name: Core Configuration
-  href: core-configuration.md
-
-- name: Referencing Players
-  href: referencing-players.md
+  href: core-configuration.md

managed/CounterStrikeSharp.API/Core/Model/CBaseEntity.cs

@@ -12,21 +12,17 @@ public partial class CBaseEntity
     public void Teleport(Vector? position = null, QAngle? angles = null, Vector? velocity = null)
     {
         Guard.IsValidEntity(this);
-    
+
         if (position == null && angles == null && velocity == null)
             throw new ArgumentNullException("No valid argument");
-    
+
         nint _position = position?.Handle ?? 0;
         nint _angles = angles?.Handle ?? 0;
         nint _velocity = velocity?.Handle ?? 0;
         nint _handle = Handle;
 
-        if (this is CCSPlayerController player && player.PlayerPawn.Value is CCSPlayerPawn playerPawn)
-        {
-            _handle = playerPawn.Handle;
-        }
-
-        VirtualFunction.CreateVoid<IntPtr, IntPtr, IntPtr, IntPtr>(_handle, GameData.GetOffset("CBaseEntity_Teleport"))(_handle, _position, _angles, _velocity);
+        VirtualFunction.CreateVoid<IntPtr, IntPtr, IntPtr, IntPtr>(_handle, GameData.GetOffset("CBaseEntity_Teleport"))(_handle, _position,
+            _angles, _velocity);
     }
 
     /// <exception cref="InvalidOperationException">Entity is not valid</exception>

managed/CounterStrikeSharp.API/Core/Model/CCSPlayerController.cs

@@ -340,4 +340,11 @@ public partial class CCSPlayerController
             NativeAPI.SetClientVoiceFlags(Handle, (Byte)value);
         }
     }
+
+    [Obsolete(
+        "You are trying to call Teleport on a non-physical player. Maybe you mean Pawn? (See: https://docs.cssharp.dev/docs/guides/referencing-players.html#controllers--pawns)")]
+    public new void Teleport(Vector? position = null, QAngle? angles = null, Vector? velocity = null)
+    {
+        base.Teleport(position, angles, velocity);
+    }
 }

managed/CounterStrikeSharp.API/Core/Model/CTakeDamageInfo.cs

@@ -0,0 +1,32 @@
+using System.Runtime.InteropServices;
+
+namespace CounterStrikeSharp.API.Core;
+
+public partial class CTakeDamageInfo
+{
+    /// <summary>
+    /// Retrieves the hitgroup
+    /// </summary>
+    /// <returns>
+    /// Returns a <see cref="HitGroup_t"/> enumeration representing the player's current hit group,
+    /// or <see cref="HitGroup_t.HITGROUP_INVALID"/> if the hit group cannot be determined.
+    /// </returns>
+    public HitGroup_t GetHitGroup()
+    {
+        IntPtr v4 = Marshal.ReadIntPtr(Handle, 0x78);
+
+        if (v4 == nint.Zero)
+        {
+            return HitGroup_t.HITGROUP_INVALID;
+        }
+
+        IntPtr v1 = Marshal.ReadIntPtr(v4, 16);
+
+        if (v1 == nint.Zero)
+        {
+            return HitGroup_t.HITGROUP_GENERIC;
+        }
+
+        return (HitGroup_t)Marshal.ReadInt32(v1, 56);
+    }
+}