fix: wildcard bytes for signatures (resolves #123 and related issues) (#148)

configs/addons/counterstrikesharp/gamedata/gamedata.json

@@ -71,12 +71,12 @@
     "signatures": {
         "library": "server",
         "windows": "\\x48\\x89\\x5C\\x24\\x10\\x48\\x89\\x7C\\x24\\x20\\x55\\x48\\x8B\\xEC\\x48\\x83\\xEC\\x50",
-        "linux": "\\x55\\x48\\x89\\xF2\\x48\\x89\\xE5\\x41\\x54\\x49\\x89\\xFC\\x48\\x8D\\x7D\\xE0\\x48\\x83\\xEC\\x18\\x48\\x8D\\x05\\xA5"
+        "linux": "\\x55\\x48\\x89\\xF2\\x48\\x89\\xE5\\x41\\x54\\x49\\x89\\xFC\\x48\\x8D\\x2A\\x2A\\x48\\x83\\x2A\\x2A\\x2A\\x8D\\x05\\x2A\\x2A\\x2A\\x00\\x48\\x8B\\x30\\x48\\x8B\\x06\\xFF\\x2A\\x2A\\x48\\x8B\\x45\\x2A\\x48\\x8D\\x2A\\x2A\\x4C\\x89\\x2A\\x48\\x89\\x45\\x2A\\x2A\\x68\\xFC"
     }
   },
   "CCSPlayer_ItemServices_DropActivePlayerWeapon": {
     "offsets": {
-        "windows": 20,
+        "windows": 18,
         "linux": 19
     }
   },
@@ -103,7 +103,7 @@
     "signatures": {
         "library": "server",
         "windows": "\\x48\\x83\\xEC\\x48\\xC6\\x44\\x24\\x30\\x00\\x4C\\x8B\\xC1",
-        "linux": "\\x48\\x8D\\x05\\xC9\\xC2\\xBC"
+        "linux": "\\x48\\x8D\\x05\\x2A\\x2A\\x2A\\x2A\\x55\\x48\\x89\\xFA"
       }
   },
   "CBaseEntity_DispatchSpawn": {

managed/CounterStrikeSharp.API/Core/Application.cs

@@ -152,17 +152,7 @@ namespace CounterStrikeSharp.API.Core
                             true);
                         break;
                     }
-
-                    var plugin = _pluginContextQueryHandler.FindPluginByModulePath(info.GetArg(2));
-
-                    if (plugin == null)
-                    {
-                        info.ReplyToCommand("Could not find plugin to load.");
-                        break;
-                    }
-
-                    plugin.Load(false);
-
+                    
                     // If our arugment doesn't end in ".dll" - try and construct a path similar to PluginName/PluginName.dll.
                     // We'll assume we have a full path if we have ".dll".
                     var path = info.GetArg(2);
@@ -175,15 +165,23 @@ namespace CounterStrikeSharp.API.Core
                         path = Path.Combine(_scriptHostConfiguration.RootPath, path);
                     }
 
-                    try
-                    {
-                        // LoadPlugin(path);
-                    }
-                    catch (Exception e)
-                    {
-                        Logger.LogError(e, "Failed to load plugin from {Path}", path);
-                    }
+                    var plugin = _pluginContextQueryHandler.FindPluginByModulePath(path);
 
+                    if (plugin == null)
+                    {
+                        try
+                        {
+                            _pluginManager.LoadPlugin(path);
+                        } catch (Exception e)
+                        {
+                            info.ReplyToCommand($"Could not load plugin \"{path}\")", true);
+                        }
+                    }
+                    else
+                    {
+                        plugin.Load(false);
+                    }
+                    
                     break;
                 }
 

managed/CounterStrikeSharp.API/Core/Plugin/Host/IPluginManager.cs

@@ -5,5 +5,6 @@ namespace CounterStrikeSharp.API.Core.Plugin.Host;
 public interface IPluginManager
 {
     public void Load();
+    public void LoadPlugin(string path);
     public IEnumerable<PluginContext> GetLoadedPlugins();
 }

managed/CounterStrikeSharp.API/Core/Plugin/Host/PluginManager.cs

@@ -45,7 +45,7 @@ public class PluginManager : IPluginManager
         return _loadedPluginContexts;
     }
 
-    private void LoadPlugin(string path)
+    public void LoadPlugin(string path)
     {
         var plugin = new PluginContext(_serviceProvider, _scriptHostConfiguration, path, _loadedPluginContexts.Select(x => x.PluginId).DefaultIfEmpty(0).Max() + 1);
         _loadedPluginContexts.Add(plugin);

managed/CounterStrikeSharp.API/Modules/Config/ConfigManager.cs

@@ -68,7 +68,7 @@ namespace CounterStrikeSharp.API.Modules.Config
                 {
                     _logger.LogError(ex, "Failed to generate configuration file for {PluginName}", pluginName);
                 }
-            } else if (File.Exists(exampleConfigPath))
+            } else if (File.Exists(exampleConfigPath) && !File.Exists(configPath))
             {
                 try
                 {