From 149787d1391dc21da0522cd7f8fbf6919d9254d6 Mon Sep 17 00:00:00 2001
From: roflmuffin <shortguy014@gmail.com>
Date: Sun, 20 Jul 2025 11:45:19 +0000
Subject: [PATCH] chore: extract ConVarCreationOptions

---
 .../Modules/Cvars/ConVarOfT.cs                | 22 +++++++++----------
 .../ConVarTests.cs                            |  6 ++---
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/managed/CounterStrikeSharp.API/Modules/Cvars/ConVarOfT.cs b/managed/CounterStrikeSharp.API/Modules/Cvars/ConVarOfT.cs
index 3e38272a..8af1e274 100644
--- a/managed/CounterStrikeSharp.API/Modules/Cvars/ConVarOfT.cs
+++ b/managed/CounterStrikeSharp.API/Modules/Cvars/ConVarOfT.cs
@@ -66,7 +66,7 @@ public class ConVar<T> : ConVarBase
     }
 
     public ConVar(string name, string description, T defaultValue = default(T), ConVarFlags flags = ConVarFlags.FCVAR_NONE,
-        T? minValue = default, T? maxValue = default) : this(new ConVarCreationOptions
+        T? minValue = default, T? maxValue = default) : this(new ConVarCreationOptions<T>
     {
         Name = name,
         DefaultValue = defaultValue,
@@ -78,7 +78,7 @@ public class ConVar<T> : ConVarBase
     {
     }
 
-    public ConVar(ConVarCreationOptions options)
+    public ConVar(ConVarCreationOptions<T> options)
     {
         var type = typeof(T);
         var conVarType = type switch
@@ -210,14 +210,14 @@ public class ConVar<T> : ConVarBase
     {
         return $"ConVar [name={Name}, value={Value}, description={Description}, type={Type}, flags={Flags}]";
     }
+}
 
-    public sealed record ConVarCreationOptions
-    {
-        public required string Name { get; init; }
-        public required T DefaultValue { get; init; }
-        public string Description { get; init; } = string.Empty;
-        public ConVarFlags Flags { get; init; } = ConVarFlags.FCVAR_NONE;
-        public T? MinValue { get; init; }
-        public T? MaxValue { get; init; }
-    }
+public sealed record ConVarCreationOptions<T>
+{
+    public required string Name { get; init; }
+    public required T DefaultValue { get; init; }
+    public string Description { get; init; } = string.Empty;
+    public ConVarFlags Flags { get; init; } = ConVarFlags.FCVAR_NONE;
+    public T? MinValue { get; init; }
+    public T? MaxValue { get; init; }
 }
\ No newline at end of file
diff --git a/managed/CounterStrikeSharp.Tests.Native/ConVarTests.cs b/managed/CounterStrikeSharp.Tests.Native/ConVarTests.cs
index 92522c73..48b35993 100644
--- a/managed/CounterStrikeSharp.Tests.Native/ConVarTests.cs
+++ b/managed/CounterStrikeSharp.Tests.Native/ConVarTests.cs
@@ -112,7 +112,7 @@ public class ConVarTests
     {
         ConVar<Vector>.Find("test_vector_convar")?.Delete();
 
-        var conVar = new ConVar<Vector>(new ConVar<Vector>.ConVarCreationOptions()
+        var conVar = new ConVar<Vector>(new ConVarCreationOptions<Vector>()
         {
             Name = "test_vector_convar",
             DefaultValue = new Vector(1, 2, 3),
@@ -172,7 +172,7 @@ public class ConVarTests
     {
         ConVar<float>.Find("test_float_convar")?.Delete();
 
-        var conVar = new ConVar<float>(new ConVar<float>.ConVarCreationOptions()
+        var conVar = new ConVar<float>(new ConVarCreationOptions<float>()
         {
             Name = "test_float_convar",
             DefaultValue = 1.23f,
@@ -209,7 +209,7 @@ public class ConVarTests
     {
         ConVar<int>.Find("test_int_convar")?.Delete();
 
-        var conVar = new ConVar<int>(new ConVar<int>.ConVarCreationOptions()
+        var conVar = new ConVar<int>(new ConVarCreationOptions<int>()
         {
             Name = "test_int_convar",
             DefaultValue = 42,